netdev - Re: regression caused by 1d2024f61ec14bdb0c57a97a3fe73685abc2d198?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130206174228.GA16991@redhat.com>
Date:	Wed, 6 Feb 2013 19:42:28 +0200
From:	"Michael S. Tsirkin" <mst@...hat.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	alexander.h.duyck@...el.com, stephen.s.ko@...el.com,
	jeffrey.t.kirsher@...el.com, David Miller <davem@...emloft.net>,
	netdev@...r.kernel.org, sony.chacko@...gic.com, mchan@...adcom.com,
	jitendra.kalsaria@...gic.com, eilong@...adcom.com
Subject: Re: regression caused by 1d2024f61ec14bdb0c57a97a3fe73685abc2d198?

On Wed, Feb 06, 2013 at 08:15:32AM -0800, Eric Dumazet wrote:
> On Wed, 2013-02-06 at 17:50 +0200, Michael S. Tsirkin wrote:
> 
> > Also, I'm not sure I understand when should drivers set gso size
> > for incoming messages and what is a reasonable value.
> > Commit log talks about improved performance for lossy connections,
> > in this case, isn't this something net core should set?
> > 
> > I see 3 in-tree drivers that do this:
> > 
> > drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c:                skb_shinfo(skb)->gso_size = bnx2x
> 
> bnx2x is fine, take a look at lines 464

Is this what you mean?

        /* This is needed in order to enable forwarding support */
        if (frag_size) {
                skb_shinfo(skb)->gso_size = bnx2x_set_lro_mss(bp,
                                        tpa_info->parsing_flags, len_on_bd);

                /* set for GRO */
                if (fp->mode == TPA_MODE_GRO)
                        skb_shinfo(skb)->gso_type =
                            (GET_FLAG(tpa_info->parsing_flags,
                                      PARSING_FLAGS_OVER_ETHERNET_PROTOCOL) ==
                                                PRS_FLAG_OVERETH_IPV6) ?
                                SKB_GSO_TCPV6 : SKB_GSO_TCPV4;
        }


I see it sets gso_type but apparently only if mode is GRO?
Will this still break if mode is set to LRO?




> > drivers/net/ethernet/intel/ixgbe/ixgbe_main.c:  skb_shinfo(skb)->gso_size = DIV_ROUND_UP((skb->le
> > drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c:         skb_shinfo(skb)->gso_size = qlcnic_get_lr
> > 
> > It seems likely the same issue applies there?
> 
> Yes
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html