netdev - Re: [PATCH 1/4] bgmac: implement missing code for BCM53572

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACna6rxrQYYs7rM53Bt6mL7zeJWzrYJKh1CYgPDO3TGwJVCyhg@mail.gmail.com>
Date:	Wed, 6 Feb 2013 15:54:13 +0100
From:	Rafał Miłecki <zajec5@...il.com>
To:	Hauke Mehrtens <hauke@...ke-m.de>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH 1/4] bgmac: implement missing code for BCM53572

2013/2/6 Hauke Mehrtens <hauke@...ke-m.de>:
>
> Signed-off-by: Hauke Mehrtens <hauke@...ke-m.de>
> ---
>  drivers/net/ethernet/broadcom/bgmac.c |    6 ++++--
>  drivers/net/ethernet/broadcom/bgmac.h |    2 +-
>  2 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c
> index 9bd33db..58e0c70 100644
> --- a/drivers/net/ethernet/broadcom/bgmac.c
> +++ b/drivers/net/ethernet/broadcom/bgmac.c
> @@ -889,8 +889,10 @@ static void bgmac_chip_reset(struct bgmac *bgmac)
>                         sw_type = et_swtype;
>                 } else if (ci->id == BCMA_CHIP_ID_BCM5357 && ci->pkg == 9) {
>                         sw_type = BGMAC_CHIPCTL_1_SW_TYPE_EPHYRMII;
> -               } else if (0) {
> -                       /* TODO */
> +               } else if ((ci->id != BCMA_CHIP_ID_BCM53572 && ci->pkg == 10) ||
> +                          (ci->id == BCMA_CHIP_ID_BCM53572 && ci->pkg == 9)) {
> +                       sw_type = BGMAC_CHIPCTL_1_IF_TYPE_RGMII |
> +                                 BGMAC_CHIPCTL_1_SW_TYPE_RGMII;

Check "chippkg is 10" looked too generous for me, that's why I didn't
implement this part. "ci->id != BCMA_CHIP_ID_BCM53572" doesn't make it
much better, but OK, if that's the way it is... ;)

Could you update specs?
http://bcm-v4.sipsolutions.net/mac-gbit/gmac/chipreset

-- 
Rafał
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html