netdev - Re: [PATCH] bgmac: validate MAC addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51128ECD.7090907@openwrt.org>
Date:	Wed, 06 Feb 2013 18:11:41 +0100
From:	Florian Fainelli <florian@...nwrt.org>
To:	Rafał Miłecki <zajec5@...il.com>
CC:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] bgmac: validate MAC addr

Hello Rafal,

On 02/06/2013 10:37 AM, Rafał Miłecki wrote:
>
> Signed-off-by: Rafał Miłecki <zajec5@...il.com>
> ---
>   drivers/net/ethernet/broadcom/bgmac.c |    5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c
> index af149a3..9f95089 100644
> --- a/drivers/net/ethernet/broadcom/bgmac.c
> +++ b/drivers/net/ethernet/broadcom/bgmac.c
> @@ -1290,6 +1290,11 @@ static int bgmac_probe(struct bcma_device *core)
>   		return -ENOTSUPP;
>   	}
>
> +	if (!is_valid_ether_addr(mac)) {
> +		dev_err(&core->dev, "Invalid MAC addr: %pM\n", mac);
> +		return -EADDRNOTAVAIL;
> +	}

Rather generate an random one, thus making the interface usable, but 
keep the warning to help users track this down.
--
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html