netdev - Re: [PATCH v3 3/3] tg3: add support for Ethernet core in bcm4785

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5113BADB.6090204@hauke-m.de>
Date:	Thu, 07 Feb 2013 15:31:55 +0100
From:	Hauke Mehrtens <hauke@...ke-m.de>
To:	Michael Chan <mchan@...adcom.com>
CC:	davem@...emloft.net, mcarlson@...adcom.com, nsujir@...adcom.com,
	netdev@...r.kernel.org, m@...s.ch
Subject: Re: [PATCH v3 3/3] tg3: add support for Ethernet core in bcm4785

On 02/07/2013 03:06 AM, Michael Chan wrote:
> On Wed, 2013-02-06 at 23:46 +0100, Hauke Mehrtens wrote: 
>> @@ -16165,7 +16256,8 @@ static int tg3_test_dma(struct tg3 *tp)
>>                         if (tg3_flag(tp, 40BIT_DMA_BUG) &&
>>                             GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5704)
>>                                 tp->dma_rwctrl |= 0x8000;
>> -                       else if (ccval == 0x6 || ccval == 0x7)
>> +                       else if ((ccval == 0x6 || ccval == 0x7) ||
>> +                                tg3_flag(tp, ONE_DMA_AT_ONCE))
> 
> This code path is only for the older 5703 and 5704.  So it won't be
> applicable for this ethernet core, right?

I just had a look into the original source provided with my Router for
this chip and you are right, this code should be placed after the checks
for specific chips. I will resend this patch series. This
ONE_DMA_AT_ONCE does not affect my Ethernet core, because this should
only be done for rev < 2 bcm4785 chips and mine is rev 2.

>>                                 tp->dma_rwctrl |= DMA_RWCTRL_ONE_DMA;
>>  
>>                         if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5703) 

Hauke
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html