netdev - Re: [PATCH] bgmac: fix "cmdcfg" calls for promisc and loopback modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 07 Feb 2013 15:55:08 +0100
From:	Florian Fainelli <florian@...nwrt.org>
To:	Rafał Miłecki <zajec5@...il.com>
CC:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	Nathan Hintz <nlhintz@...mail.com>
Subject: Re: [PATCH] bgmac: fix "cmdcfg" calls for promisc and loopback modes

Hello Rafal,

On 02/07/2013 11:23 AM, Rafał Miłecki wrote:
> This makes code match the specs.

And this probably deserves a better commit message too. Especially as 
you are inverting booleans, without the actual consumer of that boolean 
parameter being in the context of the patch.

Thanks!

>
> Reported-by: Nathan Hintz <nlhintz@...mail.com>
> Signed-off-by: Rafał Miłecki <zajec5@...il.com>
> ---
>   drivers/net/ethernet/broadcom/bgmac.c |    8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c
> index f90d1dc..8cf5e39 100644
> --- a/drivers/net/ethernet/broadcom/bgmac.c
> +++ b/drivers/net/ethernet/broadcom/bgmac.c
> @@ -776,9 +776,9 @@ static void bgmac_set_rx_mode(struct net_device *net_dev)
>   	struct bgmac *bgmac = netdev_priv(net_dev);
>
>   	if (net_dev->flags & IFF_PROMISC)
> -		bgmac_cmdcfg_maskset(bgmac, ~0, BGMAC_CMDCFG_PROM, false);
> +		bgmac_cmdcfg_maskset(bgmac, ~0, BGMAC_CMDCFG_PROM, true);
>   	else
> -		bgmac_cmdcfg_maskset(bgmac, ~BGMAC_CMDCFG_PROM, 0, false);
> +		bgmac_cmdcfg_maskset(bgmac, ~BGMAC_CMDCFG_PROM, 0, true);
>   }
>
>   #if 0 /* We don't use that regs yet */
> @@ -1039,9 +1039,9 @@ static void bgmac_chip_init(struct bgmac *bgmac, bool full_init)
>   	bgmac_write_mac_address(bgmac, bgmac->net_dev->dev_addr);
>
>   	if (bgmac->loopback)
> -		bgmac_cmdcfg_maskset(bgmac, ~0, BGMAC_CMDCFG_ML, true);
> +		bgmac_cmdcfg_maskset(bgmac, ~0, BGMAC_CMDCFG_ML, false);
>   	else
> -		bgmac_cmdcfg_maskset(bgmac, ~BGMAC_CMDCFG_ML, 0, true);
> +		bgmac_cmdcfg_maskset(bgmac, ~BGMAC_CMDCFG_ML, 0, false);
>
>   	bgmac_write(bgmac, BGMAC_RXMAX_LENGTH, 32 + ETHER_MAX_LEN);
>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html