netdev - Re: [PATCH 1/1] net: fec: fix miss init spinlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHrpEqR9u5t8fZOYRq4k_vTsEORVsNwa2C_rLaxesmusY5e9-Q@mail.gmail.com>
Date:	Thu, 7 Feb 2013 09:42:40 +0800
From:	Frank Li <lznuaa@...il.com>
To:	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
Cc:	Jim Baxter <jim_baxter@...tor.com>, netdev@...r.kernel.org
Subject: Re: [PATCH 1/1] net: fec: fix miss init spinlock

2013/2/6 Waskiewicz Jr, Peter P <peter.p.waskiewicz.jr@...el.com>:
> On 2/6/2013 1:50 AM, Frank Li wrote:
>>
>>
>> It is not easy to fix. Need put tx to NAPI poll function.
>> I will work on that after China New year holiday
>
>
> Converting Tx to NAPI is the best solution, but you can put a temporary fix
> in.  Don't take a spin_lock() in fec_enet_tx(), rather take a
> spin_lock_irqsave() since you're still in HARDIRQ context.
>

That's not help.
skb_tx_timestamp function call some function using lock, which lock
used at the other place, just call spinlock_bh.

skb_tx_timestamp seem be called only in softirq context, not irq context.

> -PJ
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html