netdev - Re: [PATCHv2-net-3.8 3/3] bnx2x: set gso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1360244244.17835.1.camel@lb-tlvb-dmitry>
Date:	Thu, 7 Feb 2013 15:37:24 +0200
From:	"Dmitry Kravkov" <dmitry@...adcom.com>
To:	"Michael S. Tsirkin" <mst@...hat.com>
cc:	netdev@...r.kernel.org, "Eilon Greenstein" <eilong@...adcom.com>,
	"Jeff Kirsher" <jeffrey.t.kirsher@...el.com>,
	"Jesse Brandeburg" <jesse.brandeburg@...el.com>,
	"Bruce Allan" <bruce.w.allan@...el.com>,
	"Carolyn Wyborny" <carolyn.wyborny@...el.com>,
	"Don Skidmore" <donald.c.skidmore@...el.com>,
	"Greg Rose" <gregory.v.rose@...el.com>,
	"Peter P Waskiewicz Jr" <peter.p.waskiewicz.jr@...el.com>,
	"Alex Duyck" <alexander.h.duyck@...el.com>,
	"John Ronciak" <john.ronciak@...el.com>,
	"Tushar Dave" <tushar.n.dave@...el.com>,
	"Jitendra Kalsaria" <jitendra.kalsaria@...gic.com>,
	"Sony Chacko" <sony.chacko@...gic.com>, linux-driver@...gic.com,
	"John Fastabend" <john.r.fastabend@...el.com>,
	"David S. Miller" <davem@...emloft.net>,
	"Jacob Keller" <jacob.e.keller@...el.com>,
	linux-kernel@...r.kernel.org, e1000-devel@...ts.sourceforge.net,
	bhutchings@...arflare.com, eric.dumazet@...il.com
Subject: Re: [PATCHv2-net-3.8 3/3] bnx2x: set gso_type

On Thu, 2013-02-07 at 15:13 +0200, Michael S. Tsirkin wrote:
> In LRO mode, bnx2x set gso_size but not gso type.
> This leads to crashes in macvtap.
> Commit cbf1de72324a8105ddcc3d9ce9acbc613faea17e
> queued for 3.9 includes a more complete fix.
> This is a minimal patch to avoid the crash, for 3.8.
> 
> Signed-off-by: Michael S. Tsirkin <mst@...hat.com>
> ---
>  drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 12 +++++-------
>  1 file changed, 5 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
> index f771ddf..a5edac8 100644
> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
> @@ -504,13 +504,11 @@ static int bnx2x_fill_frag_skb(struct bnx2x *bp, struct bnx2x_fastpath *fp,
>  		skb_shinfo(skb)->gso_size = bnx2x_set_lro_mss(bp,
>  					tpa_info->parsing_flags, len_on_bd);
>  
> -		/* set for GRO */
> -		if (fp->mode == TPA_MODE_GRO)
> -			skb_shinfo(skb)->gso_type =
> -			    (GET_FLAG(tpa_info->parsing_flags,
> -				      PARSING_FLAGS_OVER_ETHERNET_PROTOCOL) ==
> -						PRS_FLAG_OVERETH_IPV6) ?
> -				SKB_GSO_TCPV6 : SKB_GSO_TCPV4;
> +		skb_shinfo(skb)->gso_type =
> +			(GET_FLAG(tpa_info->parsing_flags,
> +				  PARSING_FLAGS_OVER_ETHERNET_PROTOCOL) ==
> +			 PRS_FLAG_OVERETH_IPV6) ?
> +			SKB_GSO_TCPV6 : SKB_GSO_TCPV4;
>  	}
>  
> 
Thanks!

Acked-by: Dmitry Kravkov <dmitry@...adcom.com>




--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html