netdev - Re: [PATCH]: fix phy_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 07 Feb 2013 23:35:47 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	oss@...at.biz
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH]: fix phy_device_free memory leak

From: Petr Malat <oss@...at.biz>
Date: Thu, 7 Feb 2013 00:07:57 +0100

> Hi,
> there is a memory leak in phy_device handling:
> phy_device_create() sets name of kobject using dev_set_name(), which allocates 
> memory using kvasprintf(), but this memory isn't freed if the underlying 
> device isn't registered properly, because kobject_cleanup() is not called in 
> that case. This can happen (and actually is happening on our machines) if 
> phy_device_register(), called by mdiobus_scan(), fails. I fixed this by the 
> attached patch, so far it's working fine.
> 
> Patch description:
> Name is freed by phy_device_free(). In the case a device is released trough 
> kobject_cleanup()->device_release()->phy_device_release(), the name is set to 
> NULL and it is not freed by phy_device_free(), because it will be freed later 
> by kobject_cleanup().
> 
> Please put me on CC, I'm not signed into the mailing list.

Please follow the directions in Documentation/SubmittingPatches, in
particular the part about providing a proper signoff.

Do not send an updated version of this patch as a reply to this thread,
instead create a completely new mailing list posting for that purpose.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html