netdev - Re: [PATCH v3 2/2 net-next] net: fec: fix spin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130207.233708.2170335376726433338.davem@davemloft.net>
Date:	Thu, 07 Feb 2013 23:37:08 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	Frank.Li@...escale.com
Cc:	lznuaa@...il.com, linux-arm-kernel@...ts.infradead.org,
	netdev@...r.kernel.org, shawn.guo@...aro.org, B38611@...escale.com,
	s.hauer@...gutronix.de
Subject: Re: [PATCH v3 2/2 net-next] net: fec: fix spin_lock dead lock

From: Frank Li <Frank.Li@...escale.com>
Date: Thu, 7 Feb 2013 08:59:59 +0800

> =========================================================
> [ INFO: possible irq lock inversion dependency detected ]
> 3.8.0-rc5+ #82 Not tainted
> ---------------------------------------------------------
> swapper/0/0 just changed the state of lock:
>  (&(&fep->hw_lock)->rlock){..-...}, at: [<8034e2f8>] fec_enet_start_xmit+0x48/0x                      2cc
> but this lock took another, SOFTIRQ-unsafe lock in the past:
> (prepare_lock){+.+.+.}
> 
> and interrupts could create inverse lock ordering between them.
> other info that might help us debug this:
> Possible interrupt unsafe locking scenario:
> 
> CPU0				CPU1
> ----				----
> lock(prepare_lock);
> 				local_irq_disable()
> 				lock(&(&fep->hw_lock)->rlock);
> 				lock(prepare_lock);
> <Interrupt>
> lock(&(&fep->hw_lock)->rlock);
> 
> *** DEADLOCK ***
> 
> Signed-off-by: Frank Li <Frank.Li@...escale.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html