netdev - Re: [PATCH net-next] macvlan: broadcast addr should be part of mc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 7 Feb 2013 18:05:17 -0800
From:	Maciej Żenczykowski <maze@...gle.com>
To:	Eric Dumazet <erdnetdev@...il.com>
Cc:	David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] macvlan: broadcast addr should be part of mc_filter

SIgned-off-by: Maciej Żenczykowski <maze@...gle.com>

On Thu, Feb 7, 2013 at 6:02 PM, Eric Dumazet <erdnetdev@...il.com> wrote:
> From: Eric Dumazet <edumazet@...gle.com>
>
> commit cd431e738509e (macvlan: add multicast filter) forgot
> the broadcast case.
>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Maciej Żenczykowski <maze@...gle.com>
> ---
>  drivers/net/macvlan.c |    3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c
> index f494da8..ce7c926 100644
> --- a/drivers/net/macvlan.c
> +++ b/drivers/net/macvlan.c
> @@ -426,6 +426,9 @@ static void macvlan_set_mac_lists(struct net_device *dev)
>                 netdev_for_each_mc_addr(ha, dev) {
>                         __set_bit(mc_hash(ha->addr), filter);
>                 }
> +
> +               __set_bit(mc_hash(dev->broadcast), filter);
> +
>                 bitmap_copy(vlan->mc_filter, filter, MACVLAN_MC_FILTER_SZ);
>         }
>         dev_uc_sync(vlan->lowerdev, dev);
>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html