netdev - Re: [patch net-next 2/7] htb: fix values in opt dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1360338849.28557.98.camel@edumazet-glaptop>
Date:	Fri, 08 Feb 2013 07:54:09 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Jiri Pirko <jiri@...nulli.us>
Cc:	netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
	jhs@...atatu.com, kuznet@....inr.ac.ru
Subject: Re: [patch net-next 2/7] htb: fix values in opt dump

On Fri, 2013-02-08 at 13:58 +0100, Jiri Pirko wrote:
> in htb_change_class() cl->buffer and cl->buffer are stored in ns.
> So in dump, convert them back to psched ticks.
> 
> Signed-off-by: Jiri Pirko <jiri@...nulli.us>
> ---
>  net/sched/sch_htb.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/sched/sch_htb.c b/net/sched/sch_htb.c
> index 476992c..14a83dc 100644
> --- a/net/sched/sch_htb.c
> +++ b/net/sched/sch_htb.c
> @@ -1135,9 +1135,9 @@ static int htb_dump_class(struct Qdisc *sch, unsigned long arg,
>  	memset(&opt, 0, sizeof(opt));
>  
>  	opt.rate.rate = cl->rate.rate_bps >> 3;
> -	opt.buffer = cl->buffer;
> +	opt.buffer = PSCHED_NS2TICKS(cl->buffer);
>  	opt.ceil.rate = cl->ceil.rate_bps >> 3;
> -	opt.cbuffer = cl->cbuffer;
> +	opt.cbuffer = PSCHED_NS2TICKS(cl->cbuffer);
>  	opt.quantum = cl->quantum;
>  	opt.prio = cl->prio;
>  	opt.level = cl->level;

Acked-by: Eric Dumazet <edumazet@...gle.com>

Isnt it a patch for net tree (and stable) ?

A bug origin (commit id/title) is welcomed to ease stable team work.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html