netdev - Re: [patch net-next v3 08/11] tbf: fix value set for q->ptokens

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130210183732.GB1602@minipsycho.orion>
Date:	Sun, 10 Feb 2013 19:37:32 +0100
From:	Jiri Pirko <jiri@...nulli.us>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
	jhs@...atatu.com, kuznet@....inr.ac.ru, j.vimal@...il.com
Subject: Re: [patch net-next v3 08/11] tbf: fix value set for q->ptokens

Sun, Feb 10, 2013 at 07:00:08PM CET, eric.dumazet@...il.com wrote:
>On Sun, 2013-02-10 at 09:51 +0100, Jiri Pirko wrote:
>> Sun, Feb 10, 2013 at 09:21:38AM CET, eric.dumazet@...il.com wrote:
>> >On Sun, 2013-02-10 at 09:18 +0100, Jiri Pirko wrote:
>> >> Sun, Feb 10, 2013 at 02:30:46AM CET, eric.dumazet@...il.com wrote:
>> >> >On Sat, 2013-02-09 at 17:45 +0100, Jiri Pirko wrote:
>> >> >> q->ptokens is in ns and we are assigning q->mtu directly to it. That is
>> >> >> wrong. psched_l2t_ns() should be used to compute correct value.
>> >> >> 
>> >> >
>> >> >
>> >> >Not clear why its a separate patch, and not folded in the 6th
>> >> 
>> >> This is independent on 6th. Would be needed even if 6th wouldn't be
>> >> there.
>> >
>> >When was this bug introduced then ?
>> 
>> This has been present since the beginning of git. I'm unable to find bk
>> repo right now to tell you bk commit :/
>
>Current code doesnt store ptokens in ns, your patch is very confusing.
>
>q->mtu is properly setup by tc command.

Now I get it. q->mtu is not bytes but time instead. I will fix my patches.

>
>Its not dev->mtu at all.
>
>I claim you fix a bug added in 6th patch.
>
>It makes no sense to me to introduce a bug in 6th and fix it in 8th.
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html