netdev - Re: [PATCH 1/2] net: calexdaxgmac: fix printing of hardware version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5118CF29.3040205@codethink.co.uk>
Date:	Mon, 11 Feb 2013 10:59:53 +0000
From:	Ben Dooks <ben.dooks@...ethink.co.uk>
To:	Rob Herring <robherring2@...il.com>
CC:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/2] net: calexdaxgmac: fix printing of hardware version

On 10/02/13 22:34, Rob Herring wrote:
> On 02/10/2013 09:38 AM, Ben Dooks wrote:
>> The current driver attempts to print netdev_info() before registering the
>> network device and allowing the name to be set. Change this print to be
>> after the network deviec has been registered, and thus has been allocated
>
> You missed the typo pointed out on the first version sent to lakml.

Oops, sorry.

>> a network device name.
>>
>> Fix the following issue:
>>
>> calxedaxgmac fff50000.ethernet (unregistered net_device): h/w version is 0x1012
>>
>> Signed-off-by: Ben Dooks<ben.dooks@...ethink.co.uk>
>
> Otherwise,
>
> Acked-by: Rob Herring<rob.herring@...xeda.com>

Thanks.


-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html