lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 10 Feb 2013 20:15:12 -0500 (EST) From: David Miller <davem@...emloft.net> To: mst@...hat.com Cc: netdev@...r.kernel.org, eilong@...adcom.com, jeffrey.t.kirsher@...el.com, jesse.brandeburg@...el.com, bruce.w.allan@...el.com, carolyn.wyborny@...el.com, donald.c.skidmore@...el.com, gregory.v.rose@...el.com, peter.p.waskiewicz.jr@...el.com, alexander.h.duyck@...el.com, john.ronciak@...el.com, tushar.n.dave@...el.com, jitendra.kalsaria@...gic.com, sony.chacko@...gic.com, linux-driver@...gic.com, john.r.fastabend@...el.com, jacob.e.keller@...el.com, linux-kernel@...r.kernel.org, e1000-devel@...ts.sourceforge.net, bhutchings@...arflare.com, eric.dumazet@...il.com Subject: Re: [PATCHv2-net-3.8 0/3] fix kernel crash with macvtap on top of LRO From: "Michael S. Tsirkin" <mst@...hat.com> Date: Thu, 7 Feb 2013 15:12:56 +0200 > At the moment, macvtap crashes are observed if macvtap is attached > to an interface with LRO enabled. > The crash in question is BUG() in macvtap_skb_to_vnet_hdr. > This happens because several drivers set gso_size but not gso_type > in incoming skbs. > This didn't use to be the case: with intel cards on 3.2 and older > kernels, with qlogic - on 3.4 and older kernels, so it's a regression if > not a recent one. > The following patches fix this for qlogic, broadcom and intel drivers. > > I tested that the patch fixes the crash for ixgbe but > don't have qlogic/broadcom hardware to test. > I also only tested TCPv4. > > Please review, and consider for 3.8. > > Changes from v1: > - added missing htons as suggested by Eric > - backported the relevant bits from > cbf1de72324a8105ddcc3d9ce9acbc613faea17e for bnx2x Applied to 'net', thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists