netdev - Re: Issue with Micrel PCI Network Driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1360604823.2701.11.camel@bwh-desktop.uk.solarflarecom.com>
Date:	Mon, 11 Feb 2013 17:47:03 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	<joseph.lutz@...atechweb.com>
CC:	<netdev@...r.kernel.org>
Subject: Re: Issue with Micrel PCI Network Driver.

On Mon, 2013-02-11 at 17:46 +0000, Ben Hutchings wrote:
> On Fri, 2013-02-08 at 17:17 -0600, Joseph Lutz wrote:
> > I am having an issue with one of the network interface drivers. The 
> > driver in question is 'drivers/net/ethernet/micrel/ksz884x.c', the 
> > driver for the Micrel-Kendin device 8841.
> > I am trying to get systemd to rename the three network interfaces in my 
> > embedded atom system. I have one of the interfaces being renamed (an 
> > Intel Corporation 82574L), but the two Micrel interfaces are not being 
> > renamed. I traced this down to the driver not populating the 
> > /sys/devices/pci* information. Instead it places the driver into 
> > /sys/devices/virtual/net/.
> [...]
> 
> Right, this driver doesn't specify the parent device (PCI device) for
> the net devices it creates.
> 
> All you should need to is add:
> 	SET_NETDEV_DEV(dev, pdev);
> underneath the call to alloc_etherdev().

Or rather:
	SET_NETDEV_DEV(dev, &pdev->dev);

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html