netdev - Re: [PATCH v11 net-next 10/12] bridge: Add vlan support to static neighbors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BECD8E8A1B550B48A1BF97C13991F60E2AFC42@avmb2.qlogic.org>
Date:	Wed, 13 Feb 2013 22:10:39 +0000
From:	Jitendra Kalsaria <jitendra.kalsaria@...gic.com>
To:	Vlad Yasevich <vyasevic@...hat.com>,
	"shemminger@...tta.com" <shemminger@...tta.com>
CC:	"bridge@...ts.linux-foundation.org" 
	<bridge@...ts.linux-foundation.org>,
	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH v11 net-next 10/12] bridge: Add vlan support to static
 neighbors


On 2/13/13 2:00 PM, "Vlad Yasevich" <vyasevic@...hat.com> wrote:

>When a user adds bridge neighbors, allow him to specify VLAN id.
>If the VLAN id is not specified, the neighbor will be added
>for VLANs currently in the ports filter list.  If no VLANs are
>configured on the port, we use vlan 0 and only add 1 entry.
>
>Signed-off-by: Vlad Yasevich <vyasevic@...hat.com>
>---
>drivers/net/ethernet/intel/ixgbe/ixgbe_main.c    |    2 +-
>drivers/net/ethernet/mellanox/mlx4/en_netdev.c   |    1 +
>drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c |    4 +-
>drivers/net/macvlan.c                            |    2 +-
>drivers/net/vxlan.c                              |    3 +-
>include/linux/netdevice.h                        |    4 +-
>include/uapi/linux/neighbour.h                   |    1 +
>net/bridge/br_fdb.c                              |  148
>+++++++++++++++++++---
>net/bridge/br_private.h                          |    6 +-
>net/core/rtnetlink.c                             |   26 +++--
>10 files changed, 162 insertions(+), 35 deletions(-)
>
>diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
>b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
>index b745194..b953168 100644
>--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
>+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
>@@ -247,8 +247,8 @@ static int qlcnic_set_mac(struct net_device *netdev,
>void *p)
>	return 0;
>}
>-static int qlcnic_fdb_del(struct ndmsg *ndm, struct net_device *netdev,
>-			const unsigned char *addr)
>+static int qlcnic_fdb_del(struct ndmsg *ndm, struct nlattr *tb[],
>+			struct net_device *netdev, const unsigned char *addr)
>{
>	struct qlcnic_adapter *adapter = netdev_priv(netdev);
>	int err = -EOPNOTSUPP;

Thanks!

Acked-by: Jitendra Kalsaria <jitendra.kalsaria@...gic.com>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html