netdev - Re: [PATCH -next 1/1] net: skbuff: fix compile error in skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130213.115221.343418412847173849.davem@davemloft.net>
Date:	Wed, 13 Feb 2013 11:52:21 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	sedat.dilek@...il.com
Cc:	james.hogan@...tec.com, sakiwit@...il.com,
	linux-kernel@...r.kernel.org, linux-next@...r.kernel.org,
	jiri@...nulli.us, netdev@...r.kernel.org
Subject: Re: [PATCH -next 1/1] net: skbuff: fix compile error in skb_panic()

From: Sedat Dilek <sedat.dilek@...il.com>
Date: Wed, 13 Feb 2013 13:41:21 +0100

> On Wed, Feb 13, 2013 at 12:20 PM, James Hogan <james.hogan@...tec.com> wrote:
>> I get the following build error on next-20130213 due to the following
>> commit:
>>
>> commit f05de73bf82fbbc00265c06d12efb7273f7dc54a ("skbuff: create
>> skb_panic() function and its wrappers").
>>
>> It adds an argument called panic to a function that uses the BUG() macro
>> which tries to call panic, but the argument masks the panic() function
>> declaration, resulting in the following error (gcc 4.2.4):
>>
>> net/core/skbuff.c In function 'skb_panic':
>> net/core/skbuff.c +126 : error: called object 'panic' is not a function
>>
> 
> [ CC linux-netdev ]
> 
> Hmm, with gcc-4.6.3 on Ubuntu/precise I don't see this... compiler-specific?

Kconfig option specific.

Applied, thanks James.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html