lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 13 Feb 2013 12:03:54 -0500 From: Neil Horman <nhorman@...driver.com> To: David Miller <davem@...emloft.net> Cc: netdev@...r.kernel.org, dan.carpenter@...cle.com Subject: Re: [PATCH] netpoll: fix smatch warnings in netpoll core code On Wed, Feb 13, 2013 at 11:57:20AM -0500, David Miller wrote: > From: Neil Horman <nhorman@...driver.com> > Date: Wed, 13 Feb 2013 11:32:42 -0500 > > > Dan Carpenter contacted me with some notes regarding some smatch warnings in the > > netpoll code, some of which I introduced with my recent netpoll locking fixes, > > some which were there prior. Specifically they were: > > > > net-next/net/core/netpoll.c:243 netpoll_poll_dev() warn: inconsistent > > returns mutex:&ni->dev_lock: locked (213,217) unlocked (210,243) > > net-next/net/core/netpoll.c:706 netpoll_neigh_reply() warn: potential > > pointer math issue ('skb_transport_header(send_skb)' is a 128 bit pointer) > > > > This patch corrects the locking imbalance (the first error), and adds some > > parenthesis to correct the second error. Tested by myself. Applies to net-next > > > > Signed-off-by: Neil Horman <nhorman@...driver.com> > > Applied, thanks Neil. > > Again, please specify in the Subject line the destination tree. Sorry dave, I specified net-next in the changelog, didn't realize you preferred it in the subject. Neil > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists