netdev - Re: [PATCH] net: Fix possible wrong checksum generation.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 13 Feb 2013 13:31:07 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	pshelar@...ira.com
Cc:	edumazet@...gle.com, netdev@...r.kernel.org, jesse@...ira.com,
	bhutchings@...arflare.com
Subject: Re: [PATCH] net: Fix possible wrong checksum generation.

From: Pravin B Shelar <pshelar@...ira.com>
Date: Mon, 11 Feb 2013 11:27:41 -0800

> Patch cef401de7be8c4e (net: fix possible wrong checksum
> generation) fixed wrong checksum calculation but it broke TSO by
> defining new GSO type but not a netdev feature for that type.
> net_gso_ok() would not allow hardware checksum/segmentation
> offload of such packets without the feature.
> 
> Following patch fixes TSO and wrong checksum. This patch uses
> same logic that Eric Dumazet used. Patch introduces new flag
> SKBTX_SHARED_FRAG if at least one frag can be modified by
> the user. but SKBTX_SHARED_FRAG flag is kept in skb shared
> info tx_flags rather than gso_type.
> 
> tx_flags is better compared to gso_type since we can have skb with
> shared frag without gso packet. It does not link SHARED_FRAG to
> GSO, So there is no need to define netdev feature for this.
> 
> Signed-off-by: Pravin B Shelar <pshelar@...ira.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html