netdev - Re: [PATCH] net: cdc_ncm: fix probing of devices with multiple control interface altsettings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130214.131516.1338992153364367929.davem@davemloft.net>
Date:	Thu, 14 Feb 2013 13:15:16 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	bjorn@...k.no
Cc:	netdev@...r.kernel.org, linux-usb@...r.kernel.org,
	gsuarez@...thmicro.com, alexey.orishko@...ricsson.com
Subject: Re: [PATCH] net: cdc_ncm: fix probing of devices with multiple
 control interface altsettings

From: Bjørn Mork <bjorn@...k.no>
Date: Wed, 13 Feb 2013 23:09:52 +0100

> commit bd329e1 ("net: cdc_ncm: do not bind to NCM compatible MBIM devices")
> added a test for a CDC MBIM altsetting, implementing the cdc_ncm part of
> MBIM backward compatibility support.  This intentionally made the driver
> behave differently for CDC NCM devices with 2 alternate settings for the
> Communication interface, depending on whether or not CONFIG_USB_NET_CDC_MBIM
> was enabled.  This is correct iff alternate setting #1 really *is* a MBIM
> setting.  If not, then NCM probing will use a different altsetting than before,
> possibly causing probing failures depending on CONFIG_USB_NET_CDC_MBIM.
> 
> Fix by setting the altsetting back to default after the test, restoring the
> previous behaviour for non MBIM devices.
> 
> This bug causes probing of Huawei E3276 devices to fail when the MBIM driver
> is enabled, because these devices have a second alternate setting with no CDC
> functional descriptors.
> 
> Cc: Greg Suarez <gsuarez@...thmicro.com>
> Cc: Alexey Orishko <alexey.orishko@...ricsson.com>
> Reported-and-tested-by: Jonathan A. <yo.natan@...mail.com>
> Signed-off-by: Bjørn Mork <bjorn@...k.no>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html