netdev - ixgbe: Regression, unsupported SFP+ modules on 10Gbit/s X520 NIC no longer work with allow_unsupported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <D76AF9B3DDF5FF49833AC0A1396549060314FBD8@s554.babiel.com>
Date:	Fri, 15 Feb 2013 01:58:10 +0100
From:	"Stefan Behte" <s.behte@...iel.com>
To:	<netdev@...r.kernel.org>
Subject: ixgbe: Regression, unsupported SFP+ modules on 10Gbit/s X520 NIC no longer work with allow_unsupported_sfp=1

Hello,

I was told to send a mail, even though I had already opened https://bugzilla.kernel.org/show_bug.cgi?id=53901.

Someone patched the ixgbe driver, and now non-intel SFPs do not work anymore, again. The issue of intel "lock-in" was discussed before here:
http://marc.info/?l=e1000-devel&m=132697406314730&w=2

A tested patch is attached.

Here is what I do:

# modinfo ixgbe | grep parm
parm:           max_vfs:Maximum number of virtual functions to allocate per physical function - default is zero and maximum value is 63 (uint)
parm:           allow_unsupported_sfp:Allow unsupported and untested SFP+ modules on 82599-based adapters (uint)
parm:           debug:Debug level (0=none,...,16=all) (int)

# modprobe -r ixgbe
# modprobe ixgbe allow_unsupported_sfp=0
# dmesg | grep ixgbe
[13690.355090] ixgbe: Intel(R) 10 Gigabit PCI Express Network Driver - version 3.9.15-k
[13690.355092] ixgbe: Copyright (c) 1999-2012 Intel Corporation.
[13690.373128] ixgbe 0000:02:00.0: failed to load because an unsupported SFP+ module type was detected.
[13690.373177] ixgbe 0000:02:00.0: Reload the driver after installing a supported module.
[13690.390987] ixgbe 0000:02:00.1: failed to load because an unsupported SFP+ module type was detected.
[13690.391036] ixgbe 0000:02:00.1: Reload the driver after installing a supported module.

# modprobe -r ixgbe
# modprobe ixgbe allow_unsupported_sfp=1
# dmesg | grep ixgbe
[13679.088849] dca service started, version 1.12.1
[13679.091174] ixgbe: Intel(R) 10 Gigabit PCI Express Network Driver - version 3.9.15-k
[13679.091177] ixgbe: Copyright (c) 1999-2012 Intel Corporation.
[13679.109194] ixgbe 0000:02:00.0: failed to load because an unsupported SFP+ module type was detected.
[13679.109243] ixgbe 0000:02:00.0: Reload the driver after installing a supported module.
[13679.127399] ixgbe 0000:02:00.1: failed to load because an unsupported SFP+ module type was detected.
[13679.127450] ixgbe 0000:02:00.1: Reload the driver after installing a supported module.
[13690.352712] dca service started, version 1.12.1


With the patch:

# modprobe -r ixgbe
# modprobe ixgbe allow_unsupported_sfp=0
# dmesg | grep ixgbe
[13907.870087] ixgbe: Intel(R) 10 Gigabit PCI Express Network Driver - version 3.9.15-k
[13907.870089] ixgbe: Copyright (c) 1999-2012 Intel Corporation.
[13907.888106] ixgbe 0000:02:00.0: failed to load because an unsupported SFP+ module type was detected.
[13907.888155] ixgbe 0000:02:00.0: Reload the driver after installing a supported module.
[13907.906187] ixgbe 0000:02:00.1: failed to load because an unsupported SFP+ module type was detected.
[13907.906237] ixgbe 0000:02:00.1: Reload the driver after installing a supported module.


# modprobe -r ixgbe
# modprobe ixgbe allow_unsupported_sfp=1
# dmesg | grep ixgbe
[13914.534758] ixgbe: Intel(R) 10 Gigabit PCI Express Network Driver - version3.9.15-k
[13914.534761] ixgbe: Copyright (c) 1999-2012 Intel Corporation.
[13914.552820] ixgbe 0000:02:00.0 (unregistered net_device): WARNING: Intel (R) Network Connections are quality tested using Intel (R) Ethernet Optics.  Using untested modules is not supported and may cause unstable operation or damage to
the module or the adapter.  Intel Corporation is not responsible for any harm caused by using untested modules.
[13917.741931] ixgbe 0000:02:00.0: irq 50 for MSI/MSI-X
[13917.741938] ixgbe 0000:02:00.0: irq 51 for MSI/MSI-X
[13917.741942] ixgbe 0000:02:00.0: irq 52 for MSI/MSI-X
[13917.741951] ixgbe 0000:02:00.0: irq 53 for MSI/MSI-X
[13917.741955] ixgbe 0000:02:00.0: irq 54 for MSI/MSI-X
[13917.741960] ixgbe 0000:02:00.0: irq 55 for MSI/MSI-X
[13917.741965] ixgbe 0000:02:00.0: irq 56 for MSI/MSI-X
[13917.741969] ixgbe 0000:02:00.0: irq 57 for MSI/MSI-X
[13917.741973] ixgbe 0000:02:00.0: irq 58 for MSI/MSI-X
[13917.742002] ixgbe 0000:02:00.0: Multiqueue Enabled: Rx Queue count = 8, Tx Queue count = 8
[13917.742126] ixgbe 0000:02:00.0: (PCI Express:5.0GT/s:Width x8) 90:e2:ba:37:3b:18
[13917.742207] ixgbe 0000:02:00.0: MAC: 2, PHY: 14, SFP+: 65535, PBA No: E68793-005
[13917.743461] ixgbe 0000:02:00.0: Intel(R) 10 Gigabit Network Connection
[13917.761578] ixgbe 0000:02:00.1 (unregistered net_device): WARNING: Intel (R) Network Connections are quality tested using Intel (R) Ethernet Optics.  Using untested modules is not supported and may cause unstable operation or damage to the module or the adapter.  Intel Corporation is not responsible for any harm caused by using untested modules.
[13920.948726] ixgbe 0000:02:00.1: irq 59 for MSI/MSI-X
[13920.948737] ixgbe 0000:02:00.1: irq 60 for MSI/MSI-X
[13920.948742] ixgbe 0000:02:00.1: irq 61 for MSI/MSI-X
[13920.948746] ixgbe 0000:02:00.1: irq 62 for MSI/MSI-X
[13920.948751] ixgbe 0000:02:00.1: irq 63 for MSI/MSI-X
[13920.948757] ixgbe 0000:02:00.1: irq 64 for MSI/MSI-X
[13920.948761] ixgbe 0000:02:00.1: irq 65 for MSI/MSI-X
[13920.948767] ixgbe 0000:02:00.1: irq 66 for MSI/MSI-X
[13920.948774] ixgbe 0000:02:00.1: irq 67 for MSI/MSI-X
[13920.948803] ixgbe 0000:02:00.1: Multiqueue Enabled: Rx Queue count = 8, Tx Queue count = 8
[13920.948927] ixgbe 0000:02:00.1: (PCI Express:5.0GT/s:Width x8) 90:e2:ba:37:3b:19
[13920.949008] ixgbe 0000:02:00.1: MAC: 2, PHY: 14, SFP+: 65535, PBA No: E68793-005
[13920.950237] ixgbe 0000:02:00.1: Intel(R) 10 Gigabit Network Connection

And then I get two nice Interfaces. Please apply. :)


Best regards,

Stefan Behte

Babiel GmbH
Moskauer Strasse 27
D-40227 Düsseldorf

Tel:    0211-179349 0
Fax:    0211-179349 29
E-Mail: S.Behte@...iel.com
Internet: http://www.babiel.com

Geschäftsführer: Georg Babiel, Dr. Rainer Babiel, Harald Babiel
Amtsgericht Düsseldorf HRB 38633

~~~~~~~~~~~~~~ DISCLAIMER ~~~~~~~~~~~~~~~

The information transmitted in this electronic mail message may contain confidential and or privileged materials. Any review, retransmission, dissemination or other use of or taking of any action in reliance upon, this information by persons or entities other than the intended recipient is prohibited. If you receive such e-mails in error, please contact the sender and delete the material from any computer.

Download attachment "ixgbe-allow-non-intel-sfp-again.patch" of type "application/octet-stream" (671 bytes)