netdev - Re: [PATCH] tcp: sysctl to disable TCP simultaneous connect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jJKQSDo61TD0Jgn9Gq8TL2rCUVbA=Kq4AvfeFUb2FdJMw@mail.gmail.com>
Date:	Thu, 14 Feb 2013 22:41:39 -0800
From:	Kees Cook <keescook@...omium.org>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
Cc:	Stephen Hemminger <stephen@...workplumber.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Rob Landley <rob@...dley.net>,
	"David S. Miller" <davem@...emloft.net>,
	Alexey Kuznetsov <kuznet@....inr.ac.ru>,
	James Morris <jmorris@...ei.org>,
	Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
	Patrick McHardy <kaber@...sh.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Neil Horman <nhorman@...driver.com>,
	Yuchung Cheng <ycheng@...gle.com>,
	Shan Wei <davidshan@...cent.com>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	netdev@...r.kernel.org, Willy Tarreau <w@....eu>
Subject: Re: [PATCH] tcp: sysctl to disable TCP simultaneous connect

On Thu, Feb 14, 2013 at 9:30 PM, Eric W. Biederman
<ebiederm@...ssion.com> wrote:
> Kees Cook <keescook@...omium.org> writes:
>
>> The patch would not break it -- it defaults the sysctl to staying enabled.
>>
>> If you mean the documentation should be updated, sure, that's easy to do.
>>
>> David: I know you aren't a fan of this patch, but I'd like to try to
>> convince you. :) This leaves the feature enabled and add a toggle for
>> systems (like Chrome OS) that don't want to risk this DoS at all.
>> There are so very many other toggle, I don't see why this one would be
>> a problem to add.
>
> Chrome OS has no plans to implement webrtc?  Last I had read that
> support had been added to the release versions of Chrome, and was in the
> development builds of firefox.  I really don't belive that there are
> many systems that don't intend to run a web browser.

I haven't looked at the internals of webrtc. Are you implying some
feature in it relies on the TCP simultaneous connect?

-Kees

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html