[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1360923919-7203-4-git-send-email-tparkin@katalix.com>
Date: Fri, 15 Feb 2013 10:25:16 +0000
From: Tom Parkin <tparkin@...alix.com>
To: netdev@...r.kernel.org
Cc: jchapman@...alix.com, celston@...alix.com,
Tom Parkin <tparkin@...alix.com>
Subject: [RFC PATCH 3/6] l2tp: drop session refs in l2tp_tunnel_closeall
l2tp_tunnel_closeall is intended to close and free all sessions running in a
given tunnel. It lacked a session dereference, however, meaning these
sessions would all leak rather than being properly freed.
Add a session deref call in l2tp_tunnel_closeall to prevent this leak.
---
net/l2tp/l2tp_core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/l2tp/l2tp_core.c b/net/l2tp/l2tp_core.c
index 3842f67..7f3ab65 100644
--- a/net/l2tp/l2tp_core.c
+++ b/net/l2tp/l2tp_core.c
@@ -1328,6 +1328,8 @@ again:
if (session->deref != NULL)
(*session->deref)(session);
+ l2tp_session_dec_refcount(session);
+
write_lock_bh(&tunnel->hlist_lock);
/* Now restart from the beginning of this hash
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists