netdev - Re: [PATCH net-next 2/3] net: factor out skb_mac_gso_segment() from skb_gso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1360888321.6884.65.camel@edumazet-glaptop>
Date:	Thu, 14 Feb 2013 16:32:01 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Pravin B Shelar <pshelar@...ira.com>
Cc:	netdev@...r.kernel.org, edumazet@...gle.com, jesse@...ira.com,
	bhutchings@...arflare.com, mirqus@...il.com
Subject: Re: [PATCH net-next 2/3] net: factor out skb_mac_gso_segment() from
 skb_gso_segment()

On Thu, 2013-02-14 at 11:44 -0800, Pravin B Shelar wrote:
> This function will be used in next GRE_GSO patch. This patch does
> not change any functionality. It only exports skb_mac_gso_segment()
> function.
> 
> Signed-off-by: Pravin B Shelar <pshelar@...ira.com>
...

> +struct sk_buff *__skb_gso_segment(struct sk_buff *skb,
> +				  netdev_features_t features, bool tx_path)
> +{
> +

...

> +
> +	skb_reset_mac_header(skb);
> +	skb->mac_len = skb->network_header - skb->mac_header;

This could use skb_reset_mac_len() helper, but thats a minor point.

Acked-by: Eric Dumazet <edumazet@...gle.com>



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html