netdev - Re: [Patch net-next v2] netpoll: add some missing _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1360987823.19353.42.camel@edumazet-glaptop>
Date:	Fri, 15 Feb 2013 20:10:23 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Cong Wang <amwang@...hat.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	jiri@...nulli.us, vyasevic@...hat.com, stephen@...workplumber.org
Subject: Re: [Patch net-next v2] netpoll: add some missing __rcu marks in
 several places

On Sat, 2013-02-16 at 11:16 +0800, Cong Wang wrote:

> The reason is we don't dereference ->npinfo pointer, we just check if it
> is NULL, so doesn't need to call rcu_dereference(). Or am I missing
> anything?

Yes you are missing that the right thing to do is to use
rcu_access_pointer()

Sparse errors should not be fixed using random RCU verbs,
please be more careful.


diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
index 05c5efe..03e5949 100644
--- a/drivers/net/team/team.c
+++ b/drivers/net/team/team.c
@@ -950,7 +950,7 @@ static void team_port_disable_netpoll(struct team_port *port)
 
 static struct netpoll_info *team_netpoll_info(struct team *team)
 {
-	return team->dev->npinfo;
+	return rcu_access_pointer(team->dev->npinfo);
 }
 
 #else


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html