netdev - Re: tg3 question: Why use misc_host_ctrl not pci_chip_rev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1361048057.2240.1.camel@LTIRV-MCHAN1.corp.ad.broadcom.com>
Date:	Sat, 16 Feb 2013 12:54:17 -0800
From:	"Michael Chan" <mchan@...adcom.com>
To:	"Joe Perches" <joe@...ches.com>
cc:	netdev <netdev@...r.kernel.org>, "Jeff Garzik" <jeff@...zik.org>,
	"David Miller" <davem@...emloft.net>,
	"Matt Carlson" <mcarlson@...adcom.com>
Subject: Re: tg3 question: Why use misc_host_ctrl not pci_chip_rev_id
 here?

On Fri, 2013-02-15 at 14:41 -0800, Joe Perches wrote: 
> This code is in the original 2002 tg3 commit from Jeff.
> (line 15764 today)
> 
> static int tg3_get_invariants(struct tg3 *tp, const struct pci_device_id *ent)
> []
> 	if ((pci_state_reg & PCISTATE_CONV_PCI_MODE) == 0 &&
> 	    !tg3_flag(tp, PCIX_TARGET_HWBUG)) {
> (15764)		u32 chiprevid = GET_CHIP_REV_ID(tp->misc_host_ctrl)
> 
> 		if (chiprevid == CHIPREV_ID_5701_A0 ||
> 		    chiprevid == CHIPREV_ID_5701_B0 ||
> 		    chiprevid == CHIPREV_ID_5701_B2 ||
> 		    chiprevid == CHIPREV_ID_5701_B5) {
> 
> This is the only test of GET_CHIP_REV_ID.
> 
> Shouldn't that GET_CHIP_REV_ID(tp->misc_host_ctrl)
> and the tests below it be converted to tests like
> 
> 	tp->pci_chip_rev_id == CHIPREV_ID_5701_A0
> 
> to be similar to all the pci_chip_rev_id tests that
> the code in the same function uses?

Yes, I agree with you that the 2 methods are the same and we should make
everything consistent.  Thanks.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html