netdev - Re: [PATCH 2/2] net: fec: Improve logging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130217150821.GF6782@S2101-09.ap.freescale.net>
Date:	Sun, 17 Feb 2013 23:08:23 +0800
From:	Shawn Guo <shawn.guo@...aro.org>
To:	Fabio Estevam <festevam@...il.com>
CC:	<davem@...emloft.net>, <s.hauer@...gutronix.de>, <marex@...x.de>,
	<netdev@...r.kernel.org>,
	Fabio Estevam <fabio.estevam@...escale.com>
Subject: Re: [PATCH 2/2] net: fec: Improve logging

On Sun, Feb 17, 2013 at 10:41:11AM -0300, Fabio Estevam wrote:
> On Sun, Feb 17, 2013 at 8:55 AM, Shawn Guo <shawn.guo@...aro.org> wrote:
> 
> >> --- a/drivers/net/ethernet/freescale/fec.c
> >> +++ b/drivers/net/ethernet/freescale/fec.c
> >> @@ -1695,7 +1695,7 @@ static void fec_reset_phy(struct platform_device *pdev)
> >>       err = devm_gpio_request_one(&pdev->dev, phy_reset,
> >>                                   GPIOF_OUT_INIT_LOW, "phy-reset");
> >>       if (err) {
> >> -             pr_debug("FEC: failed to get gpio phy-reset: %d\n", err);
> >> +             dev_err(&pdev->dev, "failed to get phy-reset-gpios: %d\n", err);
> >
> > Shouldn't dev_dbg be more like a equivalent of pr_debug?  The reason
> > why it's taken as a debug message rather than an error is that some
> > board design may not have reset line for phy.
> 
> If a board does not have a reset line for the PHY then it will not try
> to request the GPIO as per patch 1/2 of this series.

Argh, yes, you're right.  The pr_debug makes no sense any more with the
first patch in place, and it should become a error message.  But they
should be one patch rather than a series to make the most sense, IMO.

Shawn

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html