netdev - Re: [PATCH 2/2] tg3: Use different macros for pci_chip_rev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130218.124622.1089178393000360367.davem@davemloft.net>
Date:	Mon, 18 Feb 2013 12:46:22 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	mchan@...adcom.com
Cc:	joe@...ches.com, mcarlson@...adcom.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] tg3: Use different macros for pci_chip_rev_id
 accesses

From: "Michael Chan" <mchan@...adcom.com>
Date: Sat, 16 Feb 2013 14:09:45 -0800

> On Sat, 2013-02-16 at 13:20 -0800, Joe Perches wrote:
>> Upper case macros for various chip attributes are slightly
>> difficult to read and are a bit out of characterto the other
>> tg3_<foo> attribute functions.
>> 
>> Convert:
>> 
>> GET_ASIC_REV(tp->pci_chip_rev_id)       -> tg3_asic_rev(tp)
>> GET_CHIP_REV(tp->pci_chip_rev_id)       -> tg3_chip_rev(tp)
>> 
>> Remove:
>> GET_METAL_REV(tp->pci_chip_rev_id)      -> tg3_metal_rev(tp) (unused)
>> 
>> Add:
>> tg3_chip_rev_id(tp) for tp->pci_chip_rev_id so access styles
>> are similar to tg3_asic_rev and tg3_chip_rev.
>> 
>> These macros are not converted to static inline functions
>> because gcc (tested with 4.7.2) is currently unable to
>> optimize the object code it produces the same way and code
>> is otherwise larger.
>> 
>> Signed-off-by: Joe Perches <joe@...ches.com> 
> 
> Acked-by: Michael Chan <mchan@...adcom.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html