[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1361293287.19353.149.camel@edumazet-glaptop>
Date: Tue, 19 Feb 2013 09:01:27 -0800
From: Eric Dumazet <eric.dumazet@...il.com>
To: Jiri Pirko <jiri@...nulli.us>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
jhs@...atatu.com, kuznet@....inr.ac.ru, j.vimal@...il.com
Subject: Re: [patch net-next v5 10/11] tbf: take into account gso skbs
On Tue, 2013-02-19 at 17:46 +0100, Jiri Pirko wrote:
> About the gso_segment, do you see any cons doing that on enqueue path
> rather than dequeue?
>
It would be fine, and could be done in core stack instead of qdisc.
netif_skb_features() for example has the following (incomplete) check
if (skb_shinfo(skb)->gso_segs > skb->dev->gso_max_segs)
features &= ~NETIF_F_GSO_MASK;
We do have a dev->gso_max_size, but its currently used in TCP stack to
size the skbs built in tcp_sendmsg().
In a forwarding workload, it seems we dont use/check gso_max_size.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists