netdev - Re: [PATCH net-next v2 2/2] ip_gre: propogate target device GSO capability to the tunnel device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANvJab2wKiQjZ=ZEuJO1A=jCnja==a0qL8XULSAU2dc6W-rh3A@mail.gmail.com>
Date:	Tue, 19 Feb 2013 10:39:44 -0800
From:	pravin <pravin.shelar@...il.com>
To:	Dmitry Kravkov <dmitry@...adcom.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 2/2] ip_gre: propogate target device GSO
 capability to the tunnel device

On Mon, Feb 18, 2013 at 11:50 AM, Dmitry Kravkov <dmitry@...adcom.com> wrote:
>
> Signed-off-by: Dmitry Kravkov <dmitry@...adcom.com>
> ---
> Changes from v1: fixed email address
>
>
>  net/ipv4/ip_gre.c |   10 ++++++++--
>  1 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c
> index cdc31ac..31bc941 100644
> --- a/net/ipv4/ip_gre.c
> +++ b/net/ipv4/ip_gre.c
> @@ -1103,8 +1103,14 @@ static int ipgre_tunnel_bind_dev(struct net_device *dev)
>         tunnel->hlen = addend;
>         /* TCP offload with GRE SEQ is not supported. */
>         if (!(tunnel->parms.o_flags & GRE_SEQ)) {
> -               dev->features           |= NETIF_F_GSO_SOFTWARE;
> -               dev->hw_features        |= NETIF_F_GSO_SOFTWARE;
> +               /* device supports enc gso offload*/
> +               if (tdev->hw_enc_features & NETIF_F_GRE_GSO) {
> +                       dev->features           |= NETIF_F_TSO;
> +                       dev->hw_features        |= NETIF_F_TSO;
> +               } else {
> +                       dev->features           |= NETIF_F_GSO_SOFTWARE;
> +                       dev->hw_features        |= NETIF_F_GSO_SOFTWARE;
> +               }
>         }

I am not sure about this change, Are you trying to limit GRE TSO to
just IPV4  in case of GRE offload in hardware?

>
>         return mtu;
> --
> 1.7.7.2
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html