netdev - Re: [MacVLAN] failure to deliver reassembled IPv6 multicast traffic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1361313484.19353.172.camel@edumazet-glaptop>
Date:	Tue, 19 Feb 2013 14:38:04 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Ben Greear <greearb@...delatech.com>
Cc:	Erik Hugne <erik.hugne@...csson.com>, netdev@...r.kernel.org,
	kaber@...sh.net, ataschner@...e.com
Subject: Re: [MacVLAN] failure to deliver reassembled IPv6 multicast traffic

On Tue, 2013-02-19 at 14:22 -0800, Ben Greear wrote:
> On 02/15/2013 11:35 AM, Eric Dumazet wrote:
> > On Fri, 2013-02-15 at 11:27 -0800, Ben Greear wrote:
> >
> >> For some reason I was thinking this wasn't fully fixed for IPv4, but
> >> maybe it is..the bug in our internal tracker only mentions IPv6
> >> as having issues...
> >>
> >> We'll do some testing on IPv4 sometime soon to make sure, and can test
> >> IPv6 patches as well...
> >
> > This worries me a bit, as I wrote this patch because you reported the
> > issue.
> 
> We just did some testing on this on the 3.7.6+ kernel.  IPv4 multicast to
> mac-vlans works OK with large packets if there is a single multicast receiver,
> but does NOT work if there are multiple multicast receivers (ie, several
> mac-vlans with an mcast receive bound to each mvlan).
> 
> Our setup also involves routing rules and send-to-self rules,
> with sender on the same machine, but I'm not sure that matters
> too much or not.

It might matter, because before commit 6d1ccff627806829c (net: reset mac
header in dev_start_xmit() ), we were accessing wrong ethernet header in
macvlan_broadcast() in the send-to-self path

struct ethhdr *eth = eth_hdr(skb);

was simply wrong.

You should try net-next and if it still fails, maybe share your test
programs.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html