netdev - Re: [PATCH net-next v2 3/3] bonding: fix bond_release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130219.005309.422120147438064243.davem@davemloft.net>
Date:	Tue, 19 Feb 2013 00:53:09 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	fubar@...ibm.com
Cc:	nikolay@...hat.com, netdev@...r.kernel.org, andy@...yhouse.net
Subject: Re: [PATCH net-next v2 3/3] bonding: fix bond_release_all
 inconsistencies

From: Jay Vosburgh <fubar@...ibm.com>
Date: Mon, 18 Feb 2013 19:12:01 -0800

> Nikolay Aleksandrov <nikolay@...hat.com> wrote:
> 
>>This patch fixes the following inconsistencies in bond_release_all:
>>- IFF_BONDING flag is not stripped from slaves
>>- MTU is not restored
>>- no netdev notifiers are sent
>>Instead of trying to keep bond_release and bond_release_all in sync
>>I think we can re-use bond_release as the environment for calling it
>>is correct (RTNL is held). I have been running tests for the past
>>week and they came out successful. The only way for bond_release to fail
>>is for the slave to be attached in a different bond or to not be a slave
>>but that cannot happen as RTNL is held and no slave manipulations can be
>>achieved.
>>
>>V2: As suggested bond_release is renamed to __bond_release_one with a
>>new parameter "all" introduced so to avoid calling unnecessary code while
>>destroying a bond, and a wrapper for it called bond_release is created
>>because of ndo_del_link. bond_release_all() is removed.
>>
>>Signed-off-by: Nikolay Aleksandrov <nikolay@...hat.com>
> 
> Signed-off-by: Jay Vosburgh <fubar@...ibm.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html