[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20130219.005350.884548712379647615.davem@davemloft.net>
Date: Tue, 19 Feb 2013 00:53:50 -0500 (EST)
From: David Miller <davem@...emloft.net>
To: fabio.estevam@...escale.com
Cc: shawn.guo@...aro.org, marex@...x.de, s.hauer@...gutronix.de,
netdev@...r.kernel.org
Subject: Re: [PATCH v4] net: fec: Do a sanity check on the gpio number
From: Fabio Estevam <fabio.estevam@...escale.com>
Date: Mon, 18 Feb 2013 17:20:31 -0300
> Check whether the phy-reset GPIO is valid, prior to requesting it.
>
> In the case a board does not provide a phy-reset GPIO, just returns immediately.
>
> With such gpio validation in place, it is also safe to change from pr_debug to
> dev_err in the case the gpio request fails.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@...escale.com>
Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists