lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 19 Feb 2013 07:03:10 -0300 From: Mauro Carvalho Chehab <mchehab@...hat.com> To: Borislav Petkov <bp@...en8.de> Cc: Greg KH <gregkh@...uxfoundation.org>, balbi@...com, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Steven Rostedt <rostedt@...dmis.org>, Frederic Weisbecker <fweisbec@...il.com>, Ingo Molnar <mingo@...hat.com>, JBottomley@...allels.com, linux-scsi@...r.kernel.org, davem@...emloft.net, netdev@...r.kernel.org, Doug Thompson <dougthompson@...ssion.com>, linux-edac@...r.kernel.org, rjw@...k.pl, linux-pm@...r.kernel.org Subject: Re: SYSFS "errors" Em Mon, 18 Feb 2013 23:44:05 +0100 Borislav Petkov <bp@...en8.de> escreveu: > On Mon, Feb 18, 2013 at 02:26:18PM -0800, Greg KH wrote: > > I don't know, it depends on if userspace can handle this properly or > > not. What tools rely on this sysfs file? WHat happens when they get a > > non-number in the file? The thing with "sdram_scrub_rate" is that this is not supported by any userspace application I know. I suspect that this is used by userspace scripts. So, we'll never know in advance what behavior those scripts would expect. > > I'm not aware of any, frankly speaking. > > If there are any, those tools should be able to handle the -ENODEV > they get. Now, if this gets changed this way, the read would succeed > but they'll have to parse the returned value and see that it is not an > integer. > > So I don't know either. > > But my gut feeling says to stay concervative and not touch this code - > we don't know what uses it and how much we would break by "fixing" it. > The current situation is not that big of a deal IMVHO and I'd be willing > to accept the small inconcistency versus possibly breaking userspace. I remember I saw some discussions about it in the past at bluesmoke ML, saying that -ENODEV is the expected behavior when this is not supported. Changing from -ENODEV to "N/A" will break anything that would be relying on the previous behavior. So, I think that such change will for sure break userspace. If we're willing to change it, not creating the "sdram_scrub_rate" sysfs node is less likely to affect userspace. Regards, Mauro -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists