netdev - Re: [RFC] ipv6: rt6_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <cmysjd5kttdebnlrt28jldw3.1361273432405@email.android.com>
Date:	Tue, 19 Feb 2013 06:30:32 -0500
From:	Neil Horman <nhorman@...driver.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Gao feng <gaofeng@...fujitsu.com>, Jiri Bohac <jbohac@...e.cz>
Subject: Re: [RFC] ipv6: rt6_update_expires() seems racy

Thank you Eric!  I'll look at this in detail today

Neil

Eric Dumazet <eric.dumazet@...il.com> wrote:

>Some strange crashes happen in rt6_check_expired(), with access
>to random addresses.
>
>At first glance, it looks like the RTF_EXPIRES and
>stuff added in commit 1716a96101c49186b
>(ipv6: fix problem with expired dst cache)
>are racy : same dst could be manipulated at the same time
>on different cpus.
>
>At some point, our stack believes rt->dst.from contains a dst pointer,
>while its really a jiffie value (as rt->dst.expires shares the same area
>of memory)
>
>rt6_update_expires() should be fixed, or am I missing something ?
>
>CC Neil because of https://bugzilla.redhat.com/show_bug.cgi?id=892060
>
>
>
>