netdev - Re: Kernel 3.7.2 strange warning and short system hang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1361388619.19353.221.camel@edumazet-glaptop>
Date:	Wed, 20 Feb 2013 11:30:19 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	bind@...s.net, linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: Kernel 3.7.2 strange warning and short system hang

On Wed, 2013-02-20 at 12:57 -0500, David Miller wrote:

> I've seen this pattern on several occasions and I have to wonder...
> 
> Do we really require, therefore, every NAPI driver to use dev_kfree_skb_any()
> in it's TX reclaim if it supports netpoll?
> 
> That seems completely bogus.
> 


> netpoll is supposed to provide an execution environment when it invokes
> ->poll() that is identical to the normal NAPI execution.  If that would
> be true, then this change above would be completely unnecessary.
> 
> We need to figure out what is the case here, and audit all the NAPI
> drivers to make sure they do the right thing once we know what the
> right thing actually is.

netpoll directly calls n->poll()

(poll_napi() -> poll_one_napi() -> napi->poll(napi, budget) )

Presumably it should not do that if running in interrupt context.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html