netdev - Re: [Patch] net: fix a wrong assignment in skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130220.151303.200159114555025820.davem@davemloft.net>
Date:	Wed, 20 Feb 2013 15:13:03 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	pshelar@...ira.com
Cc:	amwang@...hat.com, netdev@...r.kernel.org
Subject: Re: [Patch] net: fix a wrong assignment in skb_split()

From: Pravin Shelar <pshelar@...ira.com>
Date: Wed, 20 Feb 2013 10:42:18 -0800

> On Wed, Feb 20, 2013 at 12:51 AM, Cong Wang <amwang@...hat.com> wrote:
>> commit c9af6db4c11ccc6c3e7f1 (net: Fix possible wrong checksum generation)
>> has a suspicous piece:
>>
>>         -       skb_shinfo(skb1)->gso_type = skb_shinfo(skb)->gso_type;
>>         -
>>         +       skb_shinfo(skb)->tx_flags = skb_shinfo(skb1)->tx_flags & SKBTX_SHARED_FRAG;
>>
>> skb1 is the new skb, therefore should be on the left side of the assignment.
>> This patch fixes it.
>>
>> Cc: Pravin B Shelar <pshelar@...ira.com>
>> Cc: David S. Miller <davem@...emloft.net>
>> Signed-off-by: Cong Wang <amwang@...hat.com>
>>
> Looks good.
> 
> Acked-by: Pravin B Shelar <pshelar@...ira.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html