netdev - Re: [PATCH] net: fec: Ensure that initialization is done prior to request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130221.152724.6508078801736235.davem@davemloft.net>
Date:	Thu, 21 Feb 2013 15:27:24 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	fabio.estevam@...escale.com
Cc:	Frank.Li@...escale.com, s.hauer@...gutronix.de,
	jim_baxter@...tor.com, netdev@...r.kernel.org
Subject: Re: [PATCH] net: fec: Ensure that initialization is done prior to
 request_irq()

From: Fabio Estevam <fabio.estevam@...escale.com>
Date: Thu, 21 Feb 2013 16:21:50 -0300

> Currently request_irq() is called prior to fec_enet_init() and fec_ptp_init(), 
> which causes the following crash on a mx53qsb:
> 
> Unable to handle kernel NULL pointer dereference at virtual address 00000002
> pgd = 80004000
> [00000002] *pgd=00000000
> Internal error: Oops: 5 [#1] SMP ARM
> Modules linked in:
> CPU: 0    Not tainted  (3.8.0-rc7-next-20130215+ #346)
> PC is at fec_enet_interrupt+0xd0/0x348
> LR is at fec_enet_interrupt+0xb8/0x348
> pc : [<80372b7c>]    lr : [<80372b64>]    psr: 60000193
> sp : df855c20  ip : df855c20  fp : df855c74
> r10: 00000516  r9 : 1c000000  r8 : 00000000
> r7 : 00000000  r6 : 00000000  r5 : 00000000  r4 : df9b7800
> r3 : df9b7df4  r2 : 00000000  r1 : 00000000  r0 : df9b7d34
> 
> Ensure that such initialization functions are called prior to requesting the 
> interrupts, so that all necessary the data structures are in place when the 
> irqs occur. 
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@...escale.com>

Looks good, did you test this yourself or should we wait for others to
test it out?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html