netdev - Re: [PATCH net-next] IP_GRE: Fix IP-Identification.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALnjE+qOTnzdEjuGheRBhVC9piHdVKornV4Fv=ZubKS6ZAF6gQ@mail.gmail.com>
Date:	Thu, 21 Feb 2013 19:42:31 -0800
From:	Pravin Shelar <pshelar@...ira.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	netdev@...r.kernel.org, edumazet@...gle.com, jesse@...ira.com
Subject: Re: [PATCH net-next] IP_GRE: Fix IP-Identification.

On Thu, Feb 21, 2013 at 6:35 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> On Thu, 2013-02-21 at 18:18 -0800, Pravin B Shelar wrote:
>> Use ip_select_ident_more() to generate and account ids for all
>> segments that can be used for segments of a gso packet.
>>
>> Signed-off-by: Pravin B Shelar <pshelar@...ira.com>
>
> I am not sure it makes any sense to do that.
>
> Why is it needed ?
>

Without this patch GRE-GSO generates ip fragments with id 0,2,3,4...
for every GSO packet, which is not correct. This patch fixes it.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html