netdev - Re: [PATCH net-next] IP_GRE: Fix IP-Identification.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 21 Feb 2013 23:17:52 -0800
From:	pravin <pravin.shelar@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Pravin Shelar <pshelar@...ira.com>, netdev@...r.kernel.org,
	edumazet@...gle.com, jesse@...ira.com
Subject: Re: [PATCH net-next] IP_GRE: Fix IP-Identification.

On Thu, Feb 21, 2013 at 10:06 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> On Thu, 2013-02-21 at 19:42 -0800, Pravin Shelar wrote:
>
>> Without this patch GRE-GSO generates ip fragments with id 0,2,3,4...
>> for every GSO packet, which is not correct. This patch fixes it.
>> --
>
> I guess my question was more : Why dont we inherit ID from the inner
> packet ?
>
Its good idea. But we still need to get counter from dst if inner
packet is not ipv4.


> ip_select_ident_more() is a performance killer, as all cpus are going to
> access a shared counter in the dst.
>
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html