netdev - Re: [PATCH] ipv6: use a stronger hash for tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130221.194810.1537678610059390209.davem@davemloft.net>
Date:	Thu, 21 Feb 2013 19:48:10 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	andi@...stfloor.org
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org,
	ncardwell@...gle.com, ycheng@...gle.com
Subject: Re: [PATCH] ipv6: use a stronger hash for tcp

From: Andi Kleen <andi@...stfloor.org>
Date: Thu, 21 Feb 2013 15:49:16 -0800

> murmur3

Two multiplies per mix(), no thanks.  We might as well use a universal
hash like the one we use for ARP hashing, which incurs only one
multiply.

jhash() is definitely going to perform much better than murmur3 on a
wide range of cpus.

jhash() is just a series of simple shifts and additions to mix the
data (which every cpu can do cheaply), whereas murmur3 is jhash()'s
overhead plus two multiplies per mix pass.

For our purposes, therefore, Jenkins is still superior.

> cityhash

And cityhash uses the two multiply mix() function from murmur3, thus
has the same problem.

These hashes actually look quite terrible for kernel hash table hashes.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html