netdev - Re: [PATCH] net: Fix locking bug in netif_set_xps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130222.164437.594533687574086889.davem@davemloft.net>
Date:	Fri, 22 Feb 2013 16:44:37 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	alexander.h.duyck@...el.com
Cc:	netdev@...r.kernel.org, fengguang.wu@...el.com,
	dan.carpenter@...cle.com, jeffrey.t.kirsher@...el.com
Subject: Re: [PATCH] net: Fix locking bug in netif_set_xps_queue

From: Alexander Duyck <alexander.h.duyck@...el.com>
Date: Fri, 22 Feb 2013 13:21:09 -0800

> On 02/22/2013 12:14 PM, David Miller wrote:
>> From: Alexander Duyck <alexander.h.duyck@...el.com>
>> Date: Fri, 22 Feb 2013 08:38:44 -0800
>>
>>> Smatch found a locking bug in netif_set_xps_queue in which we were not
>>> releasing the lock in the case of an allocation failure.
>>>
>>> This change corrects that so that we release the xps_map_mutex before
>>> returning -ENOMEM in the case of an allocation failure.
>>>
>>> Signed-off-by: Alexander Duyck <alexander.h.duyck@...el.com>
>> Applied and queue up for -stable, thanks Alex.
> 
> No patch is needed for -stable.  This was something I had introduced
> into net-next when I moved the XPS logic into its own function.

Great, thanks for letting me know.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html