netdev - Re: Fw: [Bug 54231] r8169 driver regression caused by the commit aee77e4accbeb2c86b1d294cd84fec4a12dde3bd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130222230908.GB4248@electric-eye.fr.zoreil.com>
Date:	Sat, 23 Feb 2013 00:09:08 +0100
From:	Francois Romieu <romieu@...zoreil.com>
To:	Stephen Hemminger <stephen@...workplumber.org>
Cc:	netdev@...r.kernel.org, tomimo@...rcle.nullnet.fi
Subject: Re: Fw: [Bug 54231] r8169 driver regression caused by the commit aee77e4accbeb2c86b1d294cd84fec4a12dde3bd

Stephen Hemminger <stephen@...workplumber.org> :
[...]
> https://bugzilla.kernel.org/show_bug.cgi?id=54231
> 
> --- Comment #1 from Tomi Orava <tomimo@...rcle.nullnet.fi>  2013-02-22 16:40:49 ---
> Although the r8169 has been working just fine on 3.4.31 for the past 5 days, it
> seems that I missed the second DMA Burst setting in the previous patch that
> should get fixed as well:
[...]
> --- a/drivers/net/ethernet/realtek/r8169.c
> +++ b/drivers/net/ethernet/realtek/r8169.c
> @@ -4406,8 +4407,14 @@ static void rtl_set_rx_tx_config_registers(struct
> rtl8169_private *tp)
>      void __iomem *ioaddr = tp->mmio_addr;
> 
>      /* Set DMA burst size and Interframe Gap Time */
> -    RTL_W32(TxConfig, (TX_DMA_BURST << TxDMAShift) |
> -        (InterFrameGap << TxInterFrameGapShift));
> +
> +    if (tp->mac_version == RTL_GIGA_MAC_VER_11) {
> +        RTL_W32(TxConfig, (TX_DMA_BURST_512 << TxDMAShift) |
> +            (InterFrameGap << TxInterFrameGapShift));
> +    } else {
> +        RTL_W32(TxConfig, (TX_DMA_BURST << TxDMAShift) |
> +            (InterFrameGap << TxInterFrameGapShift));
> +    }
>  }

This one should not be used in the (RTL_CFG_1) 8168 / RTL_GIGA_MAC_VER_11
path.

Tomi, what does lspci say about your 8168b device ?

>  static void rtl_hw_start(struct net_device *dev)
> @@ -5148,8 +5155,13 @@ static void rtl_hw_start_8168(struct net_device *dev)
> 
>      rtl_set_rx_mode(dev);
> 
> -    RTL_W32(TxConfig, (TX_DMA_BURST << TxDMAShift) |
> -        (InterFrameGap << TxInterFrameGapShift));
> +    if (tp->mac_version == RTL_GIGA_MAC_VER_11) {
> +        RTL_W32(TxConfig, (TX_DMA_BURST_512 << TxDMAShift) |
> +            (InterFrameGap << TxInterFrameGapShift));
> +    } else {
> +        RTL_W32(TxConfig, (TX_DMA_BURST << TxDMAShift) |
> +            (InterFrameGap << TxInterFrameGapShift));
> +    }

	RTL_W32(TxConfig, (InterFrameGap << TxInterFrameGapShift) |
		(((tp->mac_version == RTL_GIGA_MAC_VER_11) ?
		 TX_DMA_BURST_512 : TX_DMA_BURST) << TxDMAShift));

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html