netdev - Re: [PATCH net] gianfar: fix compile fail for NET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 24 Feb 2013 12:04:58 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	paul.gortmaker@...driver.com
Cc:	netdev@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
	benh@...nel.crashing.org, claudiu.manoil@...escale.com,
	jianhua.xie@...escale.com
Subject: Re: [PATCH net] gianfar: fix compile fail for NET_POLL=y due to
 struct packing

From: Paul Gortmaker <paul.gortmaker@...driver.com>
Date: Sun, 24 Feb 2013 10:38:31 -0500

> Commit ee873fda3bec7c668407b837fc5519eb961fcd37 ("gianfar: Pack struct
> gfar_priv_grp into three cachelines") moved the irq number and names
> off into a separate struct and created accessors for them.  However
> it was never tested with NET_POLL enabled, and so some conversions
> that were simply overlooked went undetected until now.
> 
> Make the netpoll ones also use the gfar_irq() accessors.
> 
> Reported-by: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> Cc: Claudiu Manoil <claudiu.manoil@...escale.com>
> Cc: Jianhua Xie <jianhua.xie@...escale.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html