netdev - Re: [PATCH] net/pasemi: Fix missing coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1361748578.2281.6.camel@joe-AO722>
Date:	Sun, 24 Feb 2013 15:29:38 -0800
From:	Joe Perches <joe@...ches.com>
To:	Syam Sidhardhan <syamsidhardh@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net/pasemi: Fix missing coding style

On Sun, 2013-02-24 at 15:23 -0800, Joe Perches wrote:
> On Mon, 2013-02-25 at 04:31 +0530, Syam Sidhardhan wrote:
> > Fix missing () & { }
> []
> > diff --git a/drivers/net/ethernet/pasemi/pasemi_mac.c b/drivers/net/ethernet/pasemi/pasemi_mac.c
> []
> > @@ -1829,10 +1831,11 @@ pasemi_mac_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
> >  		dev_err(&mac->pdev->dev, "register_netdev failed with error %d\n",
> >  			err);
> >  		goto out;
> > -	} else if netif_msg_probe(mac)
> > +	} else if (netif_msg_probe(mac)) {
> >  		printk(KERN_INFO "%s: PA Semi %s: intf %d, hw addr %pM\n",
> >  		       dev->name, mac->type == MAC_TYPE_GMAC ? "GMAC" : "XAUI",
> >  		       mac->dma_if, dev->dev_addr);
> > +	}
> >  
> >  	return err;
> >  
> 
> Uncompilable since 2007!
> That argues more for removal than anything else.

Nevermind. Not true.
netif_msg_probe is already surrounded by parens.
It's just stylistic ugly.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html