netdev - Re: [PATCH] ehea: Fix possible NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130225120943.GA4830@oc0268524204.ibm.com>
Date:	Mon, 25 Feb 2013 09:09:43 -0300
From:	Thadeu Lima de Souza Cascardo <cascardo@...ux.vnet.ibm.com>
To:	Syam Sidhardhan <syamsidhardh@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] ehea: Fix possible NULL pointer dereference

On Mon, Feb 25, 2013 at 04:29:58AM +0530, Syam Sidhardhan wrote:
> Check for (queue == NULL) has to be done before accessing queue.
> 
> Signed-off-by: Syam Sidhardhan <s.syam@...sung.com>
> ---
>  drivers/net/ethernet/ibm/ehea/ehea_qmr.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/ibm/ehea/ehea_qmr.c b/drivers/net/ethernet/ibm/ehea/ehea_qmr.c
> index 9b03033..a0820f7 100644
> --- a/drivers/net/ethernet/ibm/ehea/ehea_qmr.c
> +++ b/drivers/net/ethernet/ibm/ehea/ehea_qmr.c
> @@ -103,12 +103,14 @@ out_nomem:
> 
>  static void hw_queue_dtor(struct hw_queue *queue)
>  {
> -	int pages_per_kpage = PAGE_SIZE / queue->pagesize;
> +	int pages_per_kpage;
>  	int i, nr_pages;
> 
>  	if (!queue || !queue->queue_pages)
>  		return;
> 
> +	pages_per_kpage = PAGE_SIZE / queue->pagesize;
> +
>  	nr_pages = queue->queue_length / queue->pagesize;
> 
>  	for (i = 0; i < nr_pages; i += pages_per_kpage)
> -- 
> 1.7.9.5
> 

Acked-by: Thadeu Lima de Souza Cascardo <cascardo@...ux.vnet.ibm.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html