netdev - Re: [PATCH net] bnx2x: remove dead code and make local funcs static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130224.201629.1227238267432882976.davem@davemloft.net>
Date:	Sun, 24 Feb 2013 20:16:29 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eilong@...adcom.com
Cc:	stephen@...workplumber.org, netdev@...r.kernel.org,
	dmitry@...adcom.com, yanivr@...adcom.com
Subject: Re: [PATCH net] bnx2x: remove dead code and make local funcs static

From: "Eilon Greenstein" <eilong@...adcom.com>
Date: Sun, 24 Feb 2013 22:25:20 +0200

> On Fri, 2013-02-22 at 10:01 -0800, Stephen Hemminger wrote:
>> Sparse warned about several functions that were unnecessarily global.
>> After making them static, discovered that several functions were actually never used.
>> 
>> Compile tested only.
>> 
>> Signed-off-by: Stephen Hemminger <stephen@...workplumber.org>
>> 
> 
> Hi Stephen,
> 
> Thanks for this patch. The "dead code" part is actually a missing call
> in case of PHY FW upgrade for the 84833 PHY - without it, a server
> reboot is required for the new PHY FW to take affect - but this reboot
> saving enhancement should wait until net-next is open, so I'm acking
> this patch and we will add the code back with the proper call once the
> net-next is open again.
> 
> Acked-by: Eilon Greenstein <eilong@...adcomo.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html