netdev - Re: [PATCH] net/pasemi: Fix missing coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 24 Feb 2013 20:52:16 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	joe@...ches.com
Cc:	syamsidhardh@...il.com, netdev@...r.kernel.org, olof@...om.net
Subject: Re: [PATCH] net/pasemi: Fix missing coding style

From: Joe Perches <joe@...ches.com>
Date: Sun, 24 Feb 2013 17:23:29 -0800

> On Sun, 2013-02-24 at 20:13 -0500, David Miller wrote:
>> From: Syam Sidhardhan <syamsidhardh@...il.com>
>> Date: Mon, 25 Feb 2013 04:31:19 +0530
>> 
>> > -             } else
>> > +             } else {
>> >                       freed = 2;
>> > +             }
>> 
>> Single line statements do not need braces.
> 
> I guess you didn't see the preceding block with braces.
> 
> CodingStyle:
> 
> This does not apply if only one branch of a conditional statement is a single
> statement; in the latter case use braces in both branches:

I did, and I don't think it's necessary in this case regardless
of what CodingStyle says, do you really honestly think it increases
readability enough to justify those two wasted vertical lines of
screen space?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html