netdev - netif_receive_skb return value in bridging scenario

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <675385003F19144A8CE636FC6B7BB7012F25EC@039-SN2MPN1-021.039d.mgd.msft.net>
Date:	Tue, 26 Feb 2013 14:57:12 +0000
From:	Bercaru Cristian-B43982 <B43982@...escale.com>
To:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: netif_receive_skb return value in bridging scenario

Hello!

I noticed that the return value of __netif_receive_skb is initialized to NET_RX_DROP.

If the bridging code handles the packet and successfully returns RX_HANDLER_CONSUMED, __netif_receive_skb returns the default value, NET_RX_DROP. I don't think it is fair to consider the packet dropped, since it is received successfully.

I thought the return value of __netif_receive_skb was used by Ethernet NIC drivers for updating their RX_DROP and RX_OX counters, but I studied the source code of various drivers and they seem to ignore whatever the return value. It seems strange. Then shouldn't the function header look like      " void netif_receive_skb(... "  ?

Thank you,
Cristian Bercaru

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html