netdev - Re: [PATCH] net: dev: deinit list in unregister_netdevice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1361949146.11403.21.camel@edumazet-glaptop>
Date:	Tue, 26 Feb 2013 23:12:26 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Gao feng <gaofeng@...fujitsu.com>
Cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] net: dev: deinit list in unregister_netdevice_many

On Wed, 2013-02-27 at 14:59 +0800, Gao feng wrote:
> commit ceaaec98ad99859ac90ac6863ad0a6cd075d8e0e
> "net: deinit automatic LIST_HEAD"  has already done
> part of the deinit list jobs.
> 
> This patch push list_del into unregister_netdevice_many
> to make sure the unreg_list of netdevice object has valid
> pointer always.
> 
> Cc: David S. Miller <davem@...emloft.net>
> Cc: Eric Dumazet <eric.dumazet@...il.com>
> Signed-off-by: Gao feng <gaofeng@...fujitsu.com>
> ---

I totally Nack this patch.

1) net-next is not open.

2) We spent enough time chasing bugs, I don't want to reintroduce new
ones.

And this patch introduce nice bugs. No thank you.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html